xpay-handle-pay: bugfix, handle null parameters #7958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Fixed: xpay-handle-pay: handle null parameters passed in the "param" list. Reported-by: @hMsats Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
xpay-handle-null-params
branch
from
c1a5c6e to
9e1f00b
Compare
Changelog-None: xpay-handle-pay: don't assume bolt11 param is non NULL Signed-off-by: Lagrang3 <[email protected]>
Collaborator
Author
|
I tested this with netcat command through the naked lightning-rpc socket. I don't know if we have the tools to test this with the current pyln library. UPD. Yes we can test it. I am adding regtests for this. |
Changelog-None: xpay-handle-pay: test null params in json array. Signed-off-by: Lagrang3 <[email protected]>
Contributor
|
Nice catch! We generally use dicts for param passing (it's just better for almost so uses), so I forgot about this corner case! |
Contributor
|
Hoping this fixes Zeus Wallet! |
Collaborator
|
Looks good and thanks for adding the test. ACK 4470fa3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Fixed: xpay-handle-pay: handle null parameters passed in the "param" list.
Solves issue #7953